rdblue commented on code in PR #5391: URL: https://github.com/apache/iceberg/pull/5391#discussion_r933884886
########## python/vendor/hive_metastore/ThriftHiveMetastore-remote: ########## @@ -0,0 +1,3364 @@ +#!/usr/bin/env python +# +# Autogenerated by Thrift Compiler (0.16.0) +# +# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING +# +# options string: py +# + +import pprint +import sys + +if sys.version_info[0] > 2: + from urllib.parse import urlparse +else: + from urlparse import urlparse + +from hive_metastore import ThriftHiveMetastore +from hive_metastore.ttypes import * +from thrift.protocol.TBinaryProtocol import TBinaryProtocol +from thrift.transport import ( + THttpClient, + TSocket, + TSSLSocket, + TTransport, +) + +if len(sys.argv) <= 1 or sys.argv[1] == "--help": Review Comment: Is this going to run when `hive_metastore` is imported? Since it assumes that this is the main script and calls `sys.exit(0)`, we may want to edit it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
