rdblue commented on code in PR #5391: URL: https://github.com/apache/iceberg/pull/5391#discussion_r933885961
########## python/vendor/fb303/FacebookService-remote: ########## @@ -0,0 +1,228 @@ +#!/usr/bin/env python Review Comment: Okay, it looks like this is from an ASF repository and the thrift source is licensed with ALv2, so that's good. We should just need to state in the LICENSE file that this is from Thrift (and that the Hive one is from Hive) and is licensed under ALv2. Thrift has a [boilerplate NOTICE](https://github.com/apache/thrift/blob/7a5f29d48d6b99f14190d9d7bff0e63170965087/NOTICE), so there's nothing to add to our NOTICE. [Hive's NOTICE](https://github.com/apache/hive/blob/714c260e4a7c6b147c897718a33e693699267792/NOTICE) also doesn't contain anything that would require updates to Iceberg's NOTICE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
