amogh-jahagirdar commented on code in PR #5379:
URL: https://github.com/apache/iceberg/pull/5379#discussion_r933901731
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -81,7 +81,9 @@ public class TestS3FileIO {
"s3.write.tags.tagKey1",
"TagValue1",
"s3.delete.batch-size",
- Integer.toString(batchDeletionSize));
+ Integer.toString(batchDeletionSize),
+ "s3.delete.num-threads",
+ "1");
Review Comment:
S3Mock is not handling concurrent deletions well and now that
multi-threading batch delete is passing, the testPrefixDelete is failing.. Our
integ tests should give us good coverage in this regard.
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -81,7 +81,9 @@ public class TestS3FileIO {
"s3.write.tags.tagKey1",
"TagValue1",
"s3.delete.batch-size",
- Integer.toString(batchDeletionSize));
+ Integer.toString(batchDeletionSize),
+ "s3.delete.num-threads",
+ "1");
Review Comment:
S3Mock is not handling concurrent deletions well and now that
multi-threading batch delete is passing, the testPrefixDelete is failing.. Our
integ tests give us good coverage in this regard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
