amogh-jahagirdar commented on code in PR #5379:
URL: https://github.com/apache/iceberg/pull/5379#discussion_r933907068
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java:
##########
@@ -338,10 +338,10 @@ public void testDeleteFilesSingleBatchWithRemainder()
throws Exception {
public void testPrefixList() {
S3FileIO s3FileIO = new S3FileIO(clientFactory::s3);
List<Integer> scaleSizes = Lists.newArrayList(1, 1000, 2500);
- String listPrefix = String.format("s3://%s/%s", bucketName,
"prefix-list-test");
+ String listPrefix = String.format("s3://%s/%s/%s", bucketName, prefix,
"prefix-list-test");
Review Comment:
The cleanup of the AWS integ tests involves cleaning up under bucket/prefix
where prefix is a UUID for the run of this test class. So the prefix list test
actually should go under this as well otherwise multiple runs of the integ test
for the same bcket will fail because there will be more objects than expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
