kbendick commented on PR #5392: URL: https://github.com/apache/iceberg/pull/5392#issuecomment-1200356790
I'm just catching up on this, but I wanted to address one comment: > Also, is a separate table cache a bug? Since it is only used once, what is the problem with doing it this way? Sure, this won't cache the rewritten table, but is there a behavior problem or are loads just slightly slower? The cached table here is admittedly somewhat of a hack in that it's main usage is to deal with issues we had prior to its introduction around properly quoted table names. Actually prior to its usage we passed the full name and namespace around entirely. So there very well could be another way of organizing this code, but the cache was cleaner than the previous fix (and might have had some added benefit too). Anton introduced this cache in https://github.com/apache/iceberg/pull/5247, which removed the temporarily added `FULL_IDENT` constant that needed to be passed through everywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
