manuzhang commented on code in PR #5392:
URL: https://github.com/apache/iceberg/pull/5392#discussion_r934067632
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -489,7 +490,10 @@ private String jobDesc(RewriteFileGroup group,
RewriteExecutionContext ctx) {
}
private BinPackStrategy binPackStrategy() {
- return new SparkBinPackStrategy(table, spark());
+ // Disable Adaptive Query Execution as this may change the output
partitioning of our write
+ SparkSession spark = spark().cloneSession();
+ spark.conf().set(SQLConf.ADAPTIVE_EXECUTION_ENABLED().key(), false);
+ return new SparkBinPackStrategy(table, spark);
Review Comment:
If it's moved into `spark()` then SparkSession is cloned with AQE disabled
for all `BaseSparkAction`s. I'm not sure about the side-effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
