nastra commented on code in PR #5268:
URL: https://github.com/apache/iceberg/pull/5268#discussion_r934210627
##########
core/src/main/java/org/apache/iceberg/ManifestGroup.java:
##########
@@ -184,12 +192,14 @@ public <T extends ScanTask> CloseableIterable<T>
plan(CreateTasksFunction<T> cre
specId -> {
PartitionSpec spec = specsById.get(specId);
ResidualEvaluator residuals = residualCache.get(specId);
- return new TaskContext(spec, deleteFiles, residuals,
dropStats);
+ return new TaskContext(spec, deleteFiles, residuals,
dropStats, scanMetrics);
});
Iterable<CloseableIterable<T>> tasks =
entries(
(manifest, entries) -> {
+
scanMetrics.totalDataFiles().increment(manifest.addedFilesCount());
+
scanMetrics.totalDeleteFiles().increment(manifest.deletedFilesCount());
Review Comment:
ah that makes sense, thanks for double checking this. I added option 2 and
I'm counting total data/delete files in the `ManifestReader`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
