RussellSpitzer commented on PR #5327: URL: https://github.com/apache/iceberg/pull/5327#issuecomment-1203066113
> So we could do this, today we throw an error if the table exists, but if force==true, we just call drop table. And clarify in the docs what force option does. I would probably also in the code move some the logic to read the metadataFile up and then add a Precondition that the file exists, before the if (table.exists() block) because now it will drop if force=true. > > @RussellSpitzer @flyrain does that sound like it will work ? I prefer this approach (I think I said so before :) ) I still want the default of "don't crash a table that's already there" but I like having the option of "succeed no matter what". I think "delete" + "register" is fine even if we don't swap it atomically. My original thought was for folks doing more dangerous live swaps where we are shifting between two valid metadata.json s but even a small amount of downtime for that wouldn't be a big deal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
