RussellSpitzer commented on PR #5327: URL: https://github.com/apache/iceberg/pull/5327#issuecomment-1203078101
> > I prefer this approach (I think I said so before :) ) > > Yes fine you win :). Yea the only kind of downside is if we error re-creating the table, the table is dropped as the two are not atomic. But register can just be called again in that case. Agree its not worth the complexity to implement atomicity for a small gain. I thought we could just switch the "create" to an "alter" and keep atomicity but I didn't look too much into that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
