stevenzwu commented on code in PR #5348: URL: https://github.com/apache/iceberg/pull/5348#discussion_r938005372
########## api/src/main/java/org/apache/iceberg/metrics/FixedReservoirHistogram.java: ########## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.metrics; + +import java.util.Arrays; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** + * A {@link Histogram} implementation that uses a fixed size reservoir like circular buffer. Oldest + * observation is replaced by latest observation. Review Comment: I see where the difference comes from. I was mostly thinking about the long-running streaming job, where metrics are periodically polled and reported to metrics backend. Hence bias toward recent observations makes sense. You were talking about the batch jobs where uniform sampling is more preferable (without bias toward the recent values) to get the measurements across the lifespan of the batch job (minutes or hours). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
