amogh-jahagirdar commented on code in PR #4926:
URL: https://github.com/apache/iceberg/pull/4926#discussion_r938307119
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -167,8 +200,7 @@ protected void validate(TableMetadata currentMetadata) {
@Override
public Snapshot apply() {
refresh();
- Long parentSnapshotId = base.currentSnapshot() != null ?
- base.currentSnapshot().snapshotId() : null;
+ Long parentSnapshotId = base.ref(targetBranch) != null ?
base.ref(targetBranch).snapshotId() : null;
long sequenceNumber = base.nextSequenceNumber();
// run validations from the child operation
Review Comment:
https://github.com/namrathamyske/iceberg/pull/1/files should take care of
what @rdblue is talking about here which if I'm not mistaken is more about a
cleaner abstraction for applying a change to a specific snapshot, and running a
validation to a specific snapshot which will be needed when we implement branch
support for the other producers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
