amogh-jahagirdar commented on code in PR #4926:
URL: https://github.com/apache/iceberg/pull/4926#discussion_r939699149
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -181,7 +181,7 @@ protected void validate(TableMetadata currentMetadata,
Snapshot snapshot) {}
* Apply the update's changes to the base table metadata and return the new
manifest list.
*
* @param metadataToUpdate the base table metadata to apply changes to
- * @param snapshot
+ * @param snapshot parent snapshot passed to child operations.
Review Comment:
Ah thanks for adding the commenting. Just a nit, I think this should say
something like "snapshot to apply the changes to". Child operations doesn't
make too much sense to me imo.
I think we just need to say "Apply the changes with the given metadata to
the snapshot".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
