rdblue commented on code in PR #5450:
URL: https://github.com/apache/iceberg/pull/5450#discussion_r939727695
##########
.palantir/revapi.yml:
##########
@@ -109,6 +109,12 @@ acceptedBreaks:
- code: "java.method.addedToInterface"
new: "method org.apache.iceberg.ReplacePartitions
org.apache.iceberg.ReplacePartitions::validateNoConflictingDeletes()"
justification: "Accept all changes prior to introducing API
compatibility checks"
+ - code: "java.method.addedToInterface"
+ new: "method org.apache.iceberg.UpdateTableStatistics
org.apache.iceberg.Table::updateStatistics()"
+ justification: "new API method"
+ - code: "java.method.addedToInterface"
+ new: "method org.apache.iceberg.UpdateTableStatistics
org.apache.iceberg.Transaction::updateStatistics()"
+ justification: "new API method"
Review Comment:
I don't think we want to mix in changes to the public API. It should add the
necessary structures to `TableMetadata` only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
