rdblue commented on code in PR #5450:
URL: https://github.com/apache/iceberg/pull/5450#discussion_r939728420
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1176,6 +1187,20 @@ public Builder removeBranch(String branch) {
return this;
}
+ public Builder setStatistics(StatisticsFile statisticsFile) {
Review Comment:
The method name `setStatistics` doesn't quite describe what is happening. It
seems to imply that the statistics are replaced by the file passed in, but this
is actually only replacing the statistics for a particular snapshot. I think
`setStatistics(long snapshotId, StatisticsFile statisticsFile)` is better
because it is clear you're setting the stats for an ID. That also matches
`removeStatistics(long snapshotId)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
