jackye1995 commented on code in PR #4695:
URL: https://github.com/apache/iceberg/pull/4695#discussion_r943003459
##########
aws/src/test/java/org/apache/iceberg/aws/TestAwsClientFactories.java:
##########
@@ -56,6 +58,17 @@ public void testLoadCustom() {
"should load custom class", AwsClientFactories.from(properties)
instanceof CustomFactory);
}
+ @Test
+ public void testLoadLakeFormationAwsClientFactory() {
+ AwsClientFactory awsClientFactory = new LakeFormationAwsClientFactory();
+
+ byte[] data = SerializationUtil.serializeToBytes(awsClientFactory);
+ AwsClientFactory expectedAwsClientFactory =
SerializationUtil.deserializeFromBytes(data);
+ Assert.assertTrue(
Review Comment:
this is guaranteed if serialization roundtrip succeeds. We just need to run
L65-66 and make sure it does not fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
