jackye1995 commented on code in PR #4695: URL: https://github.com/apache/iceberg/pull/4695#discussion_r947044702
########## aws/src/main/java/org/apache/iceberg/aws/lakeformation/LakeFormationAwsClientFactory.java: ########## @@ -50,13 +45,17 @@ * https://docs.aws.amazon.com/lake-formation/latest/dg/register-query-engine.html */ public class LakeFormationAwsClientFactory extends AssumeRoleAwsClientFactory { - public static final String LF_AUTHORIZED_CALLER = "LakeFormationAuthorizedCaller"; private String dbName; private String tableName; private String glueCatalogId; private String glueAccountId; + private int maxCacheSize; + private long cacheExpirationInMillis; + + private long cacheExpiryLeadTimeInMillis; + private AssumeRoleRequestIdentity assumeRoleRequestIdentity; Review Comment: nit: can use shorter name `identity` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
