amogh-jahagirdar commented on issue #5507: URL: https://github.com/apache/iceberg/issues/5507#issuecomment-1213444321
Yeah I think it makes sense to commit the SetSnapshotOperation. I remember a discussion around this came up in https://github.com/apache/iceberg/pull/4071#discussion_r837008625 for updating snapshot references. We commit the operation even if there are no changes. Another way I was thinking was in BaseTransaction we https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/BaseTransaction.java#L502 we just advance the "lastOperationCommitted" flag in the case there is no intermediate snapshots or metadata updates. That way we avoid having to do a commit in the first place because it seems as though the original concern is the extra call required for commit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
