szehon-ho commented on code in PR #5495:
URL: https://github.com/apache/iceberg/pull/5495#discussion_r946019459
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java:
##########
@@ -103,11 +102,14 @@ public class DeleteOrphanFilesSparkAction extends
BaseSparkAction<DeleteOrphanFi
implements DeleteOrphanFiles {
private static final Logger LOG =
LoggerFactory.getLogger(DeleteOrphanFilesSparkAction.class);
- private static final Splitter COMMA = Splitter.on(",");
private static final Map<String, String> EQUAL_SCHEMES_DEFAULT =
ImmutableMap.of("s3n,s3a", "s3");
Review Comment:
Is there any significance to s3:// (I imagine its an alias)? For example in
this use case are we expecting any s3:// files, or just s3a:// , s3n://? My
thought was, it might have been easier for user to just take a List(s3a://,
s3n://), and internally generate some alias, if for example s3 is never used
for anything. Or if we are expecting s3:// files, then List(s3a://, s3n://,
s3://).
Or , if you guys really want the alias "s3" maybe for logging, its more
natural I feel to have Map(s3 -> List(s3a://, s3n://)).
Anyway its not a huge point, if you guys are more attached to this way, I
guess we can just document what it is, and if the alias is significant or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
