rdblue commented on code in PR #5417:
URL: https://github.com/apache/iceberg/pull/5417#discussion_r946173750
##########
python/pyiceberg/catalog/hive.py:
##########
@@ -235,8 +235,8 @@ def identifier_to_database_and_table(
return tuple_identifier[0], tuple_identifier[1]
- def __init__(self, name: str, properties: Properties, uri: str):
- super().__init__(name, properties)
+ def __init__(self, name: str, uri: str, **properties: str):
+ super().__init__(name, **properties)
Review Comment:
We will probably want to move everything into properties, like Pydantic
does. I don't think it makes much sense to make the caller pull out certain
properties, like `uri`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
