Fokko commented on code in PR #5417:
URL: https://github.com/apache/iceberg/pull/5417#discussion_r946401206
##########
python/pyiceberg/catalog/hive.py:
##########
@@ -235,8 +235,8 @@ def identifier_to_database_and_table(
return tuple_identifier[0], tuple_identifier[1]
- def __init__(self, name: str, properties: Properties, uri: str):
- super().__init__(name, properties)
+ def __init__(self, name: str, uri: str, **properties: str):
+ super().__init__(name, **properties)
Review Comment:
I'm not sure if I fully understand. Right now you can pass the `uri` in as a
positional argument `RestCatalog(name, uri)` and also a keyword argument
`RestCatalog(name, uri=uri)`. This will automatically be mapped to `uri`. It
will also raise an error when it isn't passed in. We can also go full keyword
arguments (which is what a lot of Pythonistas recommend because it is more
readable), but I think it is nice to define the uri explicitly because it
provides autocompletion in the IDE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
