kbendick commented on PR #5550:
URL: https://github.com/apache/iceberg/pull/5550#issuecomment-1217169436
Actually, attempting to run the method without the function redeclared makes
it not usable:
See the output from running:
```
./gradlew -DsparkVersions=2.4 :iceberg-spark:iceberg-spark-2.4:jmh \
-PjmhIncludeRegex=AvroWritersBenchmark \
-PjmhOutputPath=benchmark/avro-writers-benchmark-result.txt
....
> Task :iceberg-spark:iceberg-spark-2.4:compileTestJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
> Task :iceberg-spark:iceberg-spark-2.4:compileJmhJava FAILED
/Users/kylebendickson/repos/iceberg/spark/v2.4/spark/src/jmh/java/org/apache/iceberg/spark/source/WritersBenchmark.java:130:
error: cannot find symbol
.dataFileFormat(fileFormat())
^
symbol: method fileFormat()
location: class WritersBenchmark
/Users/kylebendickson/repos/iceberg/spark/v2.4/spark/src/jmh/java/org/apache/iceberg/spark/source/WritersBenchmark.java:162:
error: cannot find symbol
unpartitionedSpec, fileFormat(), appenders, fileFactory, io,
TARGET_FILE_SIZE_IN_BYTES);
^
symbol: method fileFormat()
location: class WritersBenchmark
/Users/kylebendickson/repos/iceberg/spark/v2.4/spark/src/jmh/java/org/apache/iceberg/spark/source/WritersBenchmark.java:181:
error: cannot find symbol
.dataFileFormat(fileFormat())
^
symbol: method fileFormat()
location: class WritersBenchmark
/Users/kylebendickson/repos/iceberg/spark/v2.4/spark/src/jmh/java/org/apache/iceberg/spark/source/WritersBenchmark.java:219:
error: cannot find symbol
fileFormat(),
^
symbol: method fileFormat()
location: class WritersBenchmark
/Users/kylebendickson/repos/iceberg/spark/v2.4/spark/src/jmh/java/org/apache/iceberg/spark/source/WritersBenchmark.java:244:
error: cannot find symbol
.dataFileFormat(fileFormat())
^
symbol: method fileFormat()
location: class WritersBenchmark
/Users/kylebendickson/repos/iceberg/spark/v2.4/spark/src/jmh/java/org/apache/iceberg/spark/source/WritersBenchmark.java:282:
error: cannot find symbol
fileFormat(),
^
symbol: method fileFormat()
location: class WritersBenchmark
/Users/kylebendickson/repos/iceberg/spark/v2.4/spark/src/jmh/java/org/apache/iceberg/spark/source/WritersBenchmark.java:310:
error: cannot find symbol
.dataFileFormat(fileFormat())
^
symbol: method fileFormat()
location: class WritersBenchmark
/Users/kylebendickson/repos/iceberg/spark/v2.4/spark/src/jmh/java/org/apache/iceberg/spark/source/WritersBenchmark.java:341:
error: cannot find symbol
SparkFileWriterFactory.builderFor(table()).dataFileFormat(fileFormat()).build();
^
symbol: method fileFormat()
location: class WritersBenchmark
/Users/kylebendickson/repos/iceberg/spark/v2.4/spark/src/jmh/java/org/apache/iceberg/spark/source/WritersBenchmark.java:361:
error: cannot find symbol
return OutputFileFactory.builderFor(table(), 1,
1).format(fileFormat()).build();
^
symbol: method fileFormat()
location: class WritersBenchmark
/Users/kylebendickson/repos/iceberg/spark/v2.4/spark/src/jmh/java/org/apache/iceberg/spark/source/avro/AvroWritersBenchmark.java:36:
error: method does not override or implement a method from a supertype
@Override
^
/Users/kylebendickson/repos/iceberg/spark/v2.4/spark/src/jmh/java/org/apache/iceberg/spark/source/parquet/ParquetWritersBenchmark.java:35:
error: method does not override or implement a method from a supertype
@Override
^
11 errors
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':iceberg-spark:iceberg-spark-2.4:compileJmhJava'.
> Compilation failed; see the compiler error output for details.
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
* Get more help at https://help.gradle.org
Deprecated Gradle features were used in this build, making it incompatible
with Gradle 8.0.
You can use '--warning-mode all' to show the individual deprecation warnings
and determine if they come from your own scripts or plugins.
See
https://docs.gradle.org/7.4.2/userguide/command_line_interface.html#sec:command_line_warnings
BUILD FAILED in 7s
35 actionable tasks: 12 executed, 23 up-to-date
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
