kbendick commented on code in PR #5550:
URL: https://github.com/apache/iceberg/pull/5550#discussion_r947273270
##########
spark/v3.1/spark/src/jmh/java/org/apache/iceberg/spark/source/WritersBenchmark.java:
##########
@@ -79,6 +79,7 @@ public abstract class WritersBenchmark extends
IcebergSourceBenchmark {
private PartitionSpec unpartitionedSpec;
private PartitionSpec partitionedSpec;
+ @Override
protected abstract FileFormat fileFormat();
Review Comment:
For spark versions 3.0 and lower, the function is _not_ declared in the base
class `IcebergSourceBenchmark`. So I added it there so that all of the versions
would be consistent.
I don't _love_ this approach, and I'm happy to try removing it from there
and simply making it part of the `WritersBenchmark` instead. But at least this
is consistent and works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
