amogh-jahagirdar commented on code in PR #5555:
URL: https://github.com/apache/iceberg/pull/5555#discussion_r948512759
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -183,10 +190,11 @@ public static <T extends SdkClientBuilder> void
configureEndpoint(T builder, Str
}
public static S3Configuration s3Configuration(
- Boolean pathStyleAccess, Boolean s3UseArnRegionEnabled) {
+ Boolean pathStyleAccess, Boolean s3UseArnRegionEnabled, Boolean
s3AccelerationEnabled) {
Review Comment:
Agree, let's deprecate s3Configuration, it shouldn't be exposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
