amogh-jahagirdar commented on PR #5555:
URL: https://github.com/apache/iceberg/pull/5555#issuecomment-1218605037

   This is great! Overall LGTM but I think we should integrate this to all the 
AwsClientFactory implementations provided by Iceberg.  
   
   
https://github.com/apache/iceberg/blob/master/aws/src/main/java/org/apache/iceberg/aws/lakeformation/LakeFormationAwsClientFactory.java
 
   
   and 
   
   
https://github.com/apache/iceberg/blob/master/aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to