amogh-jahagirdar commented on code in PR #5364:
URL: https://github.com/apache/iceberg/pull/5364#discussion_r952857200
##########
core/src/main/java/org/apache/iceberg/DataTableScan.java:
##########
@@ -61,6 +61,19 @@ public TableScan appendsAfter(long fromSnapshotId) {
return appendsBetween(fromSnapshotId, currentSnapshot.snapshotId());
}
+ @Override
+ public TableScan useBranch(String name) {
Review Comment:
I finally got a chance to come back to this PR, I actually decided on the
opposite approach. There's fewer table scans where we want to fail, so I think
it makes sense to have the implementation in the parent class and then in the
child classes which don't support (like all metadata table scan, or incremental
scan) we throw an unsupported exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
