amogh-jahagirdar commented on code in PR #5364:
URL: https://github.com/apache/iceberg/pull/5364#discussion_r952864968
##########
.palantir/revapi.yml:
##########
@@ -49,20 +58,25 @@ acceptedBreaks:
new: "method java.util.List<org.apache.iceberg.ManifestFile>
org.apache.iceberg.Snapshot::deleteManifests(org.apache.iceberg.io.FileIO)"
justification: "Allow adding a new method to the interface - old method
is deprecated"
- code: "java.method.addedToInterface"
- new: "method java.util.Map<java.lang.String,
org.apache.iceberg.SnapshotRef> org.apache.iceberg.Table::refs()"
+ new: "method java.util.Map<java.lang.String,
org.apache.iceberg.SnapshotRef>\
+ \ org.apache.iceberg.Table::refs()"
justification: "Adding new refs method to Table API for easier access"
- - code: "java.method.addedToInterface"
- new: "method long
org.apache.iceberg.actions.ExpireSnapshots.Result::deletedEqualityDeleteFilesCount()"
- justification: "Interface is backward compatible, very unlikely anyone
implements this Result bean interface"
- - code: "java.method.addedToInterface"
- new: "method long
org.apache.iceberg.actions.ExpireSnapshots.Result::deletedPositionDeleteFilesCount()"
- justification: "Interface is backward compatible, very unlikely anyone
implements this Result bean interface"
- code: "java.method.addedToInterface"
new: "method long
org.apache.iceberg.actions.DeleteReachableFiles.Result::deletedEqualityDeleteFilesCount()"
- justification: "Interface is backward compatible, very unlikely anyone
implements this Result bean interface"
+ justification: "Interface is backward compatible, very unlikely anyone
implements\
+ \ this Result bean interface"
- code: "java.method.addedToInterface"
new: "method long
org.apache.iceberg.actions.DeleteReachableFiles.Result::deletedPositionDeleteFilesCount()"
- justification: "Interface is backward compatible, very unlikely anyone
implements this Result bean interface"
+ justification: "Interface is backward compatible, very unlikely anyone
implements\
+ \ this Result bean interface"
+ - code: "java.method.addedToInterface"
+ new: "method long
org.apache.iceberg.actions.ExpireSnapshots.Result::deletedEqualityDeleteFilesCount()"
+ justification: "Interface is backward compatible, very unlikely anyone
implements\
Review Comment:
I'll need to undo this, I think my spotless reformatted the revapi changes I
made and it affected previous changes as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
