kbendick commented on code in PR #4588: URL: https://github.com/apache/iceberg/pull/4588#discussion_r956503339
########## core/src/main/java/org/apache/iceberg/deletes/DeleteCounter.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.deletes; + +/** A counter to be used to count deletes as they are applied. */ +public class DeleteCounter { + + private long count = 0L; + + /** Increment the counter by one. */ + public void increment() { + count++; + } + + /** Return the current value of the counter. */ + public long get() { + return count; + } Review Comment: I’m not sure how the entire `MetricsContext` integrates with Spark and executors etc. If we don’t have existing work that uses `MetricsContext` for custom Spark metrics (particularly task level metrics), possibly we can update this code in a later PR. I know Steven handled a lot of the metrics context adjustments for Flink and @nastra did a lot of the work for that in general. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
