kbendick commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r956506186
##########
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java:
##########
@@ -282,6 +306,7 @@ public void testEqualityDeletesSpanningMultipleDataFiles()
throws IOException {
FileHelpers.writeDataFile(table, Files.localOutput(temp.newFile()),
Row.of(0), records);
table.newAppend().appendFile(dataFile).commit();
+ // At this point, the table has 7 + 8 = 15 rows, of which all but one are
in duplicate.
Review Comment:
Nit / non-blocking: it’s a little strange to me to have the whole line
comments with empty lines afterwards.
Since this is just a test and it said “at this point”, I feel like we could
move it to be directly above the next code block. But it’s just test code so I
absolutely wouldn’t block on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
