kbendick commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r956526025
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReader.java:
##########
@@ -181,8 +181,11 @@ Pair<int[], Integer>
buildPosDelRowIdMapping(PositionDeleteIndex deletedRowPosit
if (!deletedRowPositions.isDeleted(originalRowId +
rowStartPosInBatch)) {
posDelRowIdMapping[currentRowId] = originalRowId;
currentRowId++;
- } else if (hasIsDeletedColumn) {
- isDeleted[originalRowId] = true;
+ } else {
+ if (hasIsDeletedColumn) {
+ isDeleted[originalRowId] = true;
+ }
+ deletes.incrementDeleteCount();
Review Comment:
One small nit: Can we add a blank line between the if block and the metrics
increment? It’s in-line with the style guide and I think would reduce the
tendency to wonder if the final else is intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
