wypoon commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r956615382
##########
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java:
##########
@@ -282,6 +306,7 @@ public void testEqualityDeletesSpanningMultipleDataFiles()
throws IOException {
FileHelpers.writeDataFile(table, Files.localOutput(temp.newFile()),
Row.of(0), records);
table.newAppend().appendFile(dataFile).commit();
+ // At this point, the table has 7 + 8 = 15 rows, of which all but one are
in duplicate.
Review Comment:
Perhaps I'm idiosyncratic. I put the comment after the statement because the
"at this point" refers to the state after the statement has executed and not
before. (If the comment were short enough, I would have put it on the same line
as the statement, after it. That would probably be more natural.)
Nevertheless, I have now put the comments before the statements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
