amogh-jahagirdar opened a new pull request, #5666: URL: https://github.com/apache/iceberg/pull/5666
Currently, clean up of files can only occur in ExpireSnapshots if there's 1 reference (it can be either main or a single non-main branch). However, the ancestor lookup that's done is done based on the main table state. When updating expire snapshot tests which test branch deletions on a branch in this PR https://github.com/apache/iceberg/pull/5618/files, I encountered test failures due to data files being deleted which should not be for the non-main branch case. The snapshots which were getting expired were the expected snapshots, but the data files being deleted for the branch commit were unexpected because some of the manifests being reverted were unexpected because the check [here](https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/RemoveSnapshots.java#L503) would unexpectedly pass because the isFromAncestor would evaluate to false (and the rest of the checks were as expected), so the procedure would add manifests which should not be reverted to the reverted set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
