namrathamyske commented on code in PR #5666:
URL: https://github.com/apache/iceberg/pull/5666#discussion_r957587491
##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -366,11 +367,19 @@ private void removeExpiredFiles(
// Reads and deletes are done using
Tasks.foreach(...).suppressFailureWhenFinished to complete
// as much of the delete work as possible and avoid orphaned data or
manifest files.
- // this is the set of ancestors of the current table state. when removing
snapshots, this must
- // only remove files that were deleted in an ancestor of the current table
state to avoid
+ // ToDo: This will be removed when reachability analysis is done so files
across multiple
+ // branches can be removed
+ SnapshotRef branchToCleanup = Iterables.getFirst(base.refs().values(),
null);
Review Comment:
Here the expectation is that only one ref exists. Either main or branch ref.
What if it's a tag ref?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
