JonasJ-ap commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r967752306


##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -735,4 +788,73 @@ private Set<Tag> toTags(Map<String, String> properties, 
String prefix) {
   public Map<String, String> s3BucketToAccessPointMapping() {
     return s3BucketToAccessPointMapping;
   }
+
+  public boolean s3KeyIdAccessKeyConfigured() {

Review Comment:
   I made both private and renamed `s3KeyIdAccessKeyConfigured` to 
`s3KeyIdAccessKeyBothConfigured` to reveal its purpose more clearly. For 
`credentialsProvider`, I also delete its test case added in my previous commit 
since it is now a private method. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to