jackye1995 commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r964250412
##########
aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java:
##########
@@ -91,37 +93,26 @@ public void initialize(Map<String, String> properties) {
Preconditions.checkNotNull(
region, "Cannot initialize AssumeRoleClientConfigFactory with null
region");
- this.s3Endpoint = properties.get(AwsProperties.S3FILEIO_ENDPOINT);
this.tags = toTags(properties);
Review Comment:
I am taking about adding a method in `AwsProperties` called
`stsAssumeRoleTags()`, similar to `s3WriteTags()`. We can rename `toTags` as
`toS3Tags` and add your suggested method to make them clear, because `toTags`
is a private method and we can change its name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
