nastra commented on code in PR #5788:
URL: https://github.com/apache/iceberg/pull/5788#discussion_r974038414
##########
api/src/main/java/org/apache/iceberg/metrics/DefaultCounter.java:
##########
@@ -38,6 +38,11 @@ public void increment(long amount) {}
public long value() {
throw new UnsupportedOperationException("NOOP counter has no value");
}
+
+ @Override
+ public String toString() {
+ return "NOOP counter";
Review Comment:
the default implementation of `toString()` would always use `value()` and
show the `UnsupportedOperationException` in debugging sessions, thus we're just
overriding this for Counter/Timer here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
