nastra commented on code in PR #5788:
URL: https://github.com/apache/iceberg/pull/5788#discussion_r984226142
##########
core/src/test/java/org/apache/iceberg/TestScanPlanningAndReporting.java:
##########
@@ -61,16 +62,16 @@ public void scanningWithMultipleDataManifests() throws
IOException {
assertThat(scanReport.tableName()).isEqualTo(tableName);
assertThat(scanReport.snapshotId()).isEqualTo(2L);
-
assertThat(scanReport.scanMetrics().totalPlanningDuration().totalDuration())
- .isGreaterThan(Duration.ZERO);
-
assertThat(scanReport.scanMetrics().resultDataFiles().value()).isEqualTo(3);
-
assertThat(scanReport.scanMetrics().resultDeleteFiles().value()).isEqualTo(0);
-
assertThat(scanReport.scanMetrics().scannedDataManifests().value()).isEqualTo(2);
-
assertThat(scanReport.scanMetrics().skippedDataManifests().value()).isEqualTo(0);
-
assertThat(scanReport.scanMetrics().totalDataManifests().value()).isEqualTo(2);
-
assertThat(scanReport.scanMetrics().totalDeleteManifests().value()).isEqualTo(0);
-
assertThat(scanReport.scanMetrics().totalFileSizeInBytes().value()).isEqualTo(30L);
-
assertThat(scanReport.scanMetrics().totalDeleteFileSizeInBytes().value()).isEqualTo(0L);
+ ScanMetricsResult result = scanReport.scanMetrics();
+
assertThat(result.totalPlanningDuration().totalDuration()).isGreaterThan(Duration.ZERO);
+ assertThat(result.resultDataFiles().value()).isEqualTo(3);
+ assertThat(result.resultDeleteFiles().value()).isEqualTo(0);
+ assertThat(result.scannedDataManifests().value()).isEqualTo(2);
+ assertThat(result.skippedDataManifests().value()).isEqualTo(0);
+ assertThat(result.totalDataManifests().value()).isEqualTo(2);
+ assertThat(result.totalDeleteManifests().value()).isEqualTo(0);
+ assertThat(result.totalFileSizeInBytes().value()).isEqualTo(30L);
+ assertThat(result.totalDeleteFileSizeInBytes().value()).isEqualTo(0L);
Review Comment:
this makes sense and thanks for bringing this up. I realized that those were
missing in the existing tests when working on
https://github.com/apache/iceberg/pull/5792 and included/added them there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
