rdblue commented on code in PR #5690:
URL: https://github.com/apache/iceberg/pull/5690#discussion_r974825897
##########
python/pyiceberg/cli/output.py:
##########
@@ -146,32 +173,35 @@ class JsonOutput(Output):
verbose: bool
- def __init__(self, **properties: Any):
+ def __init__(self, **properties: Any) -> None:
self.verbose = properties.get("verbose", False)
def _out(self, d: Any) -> None:
print(json.dumps(d))
- def exception(self, ex: Exception):
+ def exception(self, ex: Exception) -> None:
self._out({"type": ex.__class__.__name__, "message": str(ex)})
- def identifiers(self, identifiers: List[Identifier]):
+ def identifiers(self, identifiers: List[Identifier]) -> None:
self._out([".".join(identifier) for identifier in identifiers])
- def describe_table(self, table: Table):
+ def describe_table(self, table: Table) -> None:
print(table.json())
- def describe_properties(self, properties: Properties):
+ def describe_properties(self, properties: Properties) -> None:
self._out(properties)
- def text(self, response: str):
+ def text(self, response: str) -> None:
print(json.dumps(response))
- def schema(self, schema: Schema):
+ def schema(self, schema: Schema) -> None:
print(schema.json())
- def spec(self, spec: PartitionSpec):
+ def files(self, table: Table, io: FileIO, history: bool) -> None:
+ pass
Review Comment:
Shouldn't this at least raise an exception because it is not supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
