rdblue commented on code in PR #5690:
URL: https://github.com/apache/iceberg/pull/5690#discussion_r974827165
##########
python/pyiceberg/manifest.py:
##########
@@ -128,6 +128,10 @@ class ManifestFile(IcebergBaseModel):
partitions: Optional[List[FieldSummary]] = Field()
key_metadata: Optional[bytes] = Field()
+ def fetch_manifest_entry(self, io: FileIO) -> List[ManifestEntry]:
Review Comment:
Could this have a better name? I think this is more a read than a fetch, and
I would expect the name to be plural when returning a list.
I also think this is a bit too simple. These methods should not pull entire
files of content into memory and should support projecting columns. Reading a
manifest file can be really expensive if you load all of the file metadata. We
should use a generator rather than a list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
