rdblue commented on code in PR #5780:
URL: https://github.com/apache/iceberg/pull/5780#discussion_r974831232
##########
api/src/test/java/org/apache/iceberg/metrics/TestScanReport.java:
##########
@@ -66,11 +83,12 @@ public void fromEmptyScanMetrics() {
Schema projection =
new Schema(Types.NestedField.required(1, "c1", Types.StringType.get(),
"c1"));
ScanReport scanReport =
- ScanReport.builder()
- .withTableName(tableName)
- .withProjection(projection)
- .withFilter(Expressions.alwaysTrue())
- .fromScanMetrics(ScanReport.ScanMetrics.NOOP)
+ ImmutableScanReport.builder()
+ .tableName(tableName)
+ .snapshotId(-1L)
Review Comment:
Since this is not required (and probably should have been before) can we
just set it to a reasonable value rather than passing through -1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
