rdblue commented on code in PR #5780:
URL: https://github.com/apache/iceberg/pull/5780#discussion_r974831776
##########
baseline.gradle:
##########
@@ -57,8 +57,8 @@ subprojects {
pluginManager.withPlugin('com.palantir.baseline-error-prone') {
tasks.withType(JavaCompile).configureEach {
options.errorprone.errorproneArgs.addAll (
- // error-prone is slow, don't run on tests and generated src
- '-XepExcludedPaths:.*/(test|generated-src)/.*',
+ // error-prone is slow, don't run on tests/generated-src/generated
+ '-XepExcludedPaths:.*/(test|generated-src|generated)/.*',
Review Comment:
Can we use the same `generated-src` directory? Otherwise the generated
classes don't show up in an IDE without reconfiguring. If not, we should
discuss this on the dev list to make sure everyone knows it's going to cause
trouble in IDEs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]