gaborkaszab commented on code in PR #5792:
URL: https://github.com/apache/iceberg/pull/5792#discussion_r975513880
##########
core/src/test/java/org/apache/iceberg/metrics/TestScanMetricsResultParser.java:
##########
@@ -61,15 +64,39 @@ public void missingFields() {
"{\"total-planning-duration\":{\"count\":3,\"time-unit\":\"hours\",\"total-duration\":10}}"))
.isEqualTo(
new ScanMetricsResult(
- totalPlanningDuration, null, null, null, null, null, null,
null, null));
+ totalPlanningDuration,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
Review Comment:
It's just loosely related but as the number of metrics grow this constructor
gets longer and longer. Would it make sense to have a ScanMetricsResultBuilder
that has a with...() function to set its fields?
Or even a Builder isn't needed just to give the ScanMetricsResult a
constructor without parameters and then set it's fields on demand.
If it makes sense I can implement that in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
