nastra commented on code in PR #5792:
URL: https://github.com/apache/iceberg/pull/5792#discussion_r975544991
##########
core/src/test/java/org/apache/iceberg/metrics/TestScanMetricsResultParser.java:
##########
@@ -61,15 +64,39 @@ public void missingFields() {
"{\"total-planning-duration\":{\"count\":3,\"time-unit\":\"hours\",\"total-duration\":10}}"))
.isEqualTo(
new ScanMetricsResult(
- totalPlanningDuration, null, null, null, null, null, null,
null, null));
+ totalPlanningDuration,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
Review Comment:
I completely agree with your observation, since it just adds visual noise.
In fact https://github.com/apache/iceberg/pull/5780 will provide exactly that
functionality out of the box. I'm planning to get
https://github.com/apache/iceberg/pull/5780 first in and then I'll be rebasing
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
