jfz commented on code in PR #5812:
URL: https://github.com/apache/iceberg/pull/5812#discussion_r976957163
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -521,7 +521,7 @@ public AwsProperties() {
this.s3DeleteTags = Sets.newHashSet();
this.s3FileIoDeleteThreads = Runtime.getRuntime().availableProcessors();
this.isS3DeleteEnabled = S3_DELETE_ENABLED_DEFAULT;
- this.s3BucketToAccessPointMapping = ImmutableMap.of();
+ this.s3BucketToAccessPointMapping = Collections.emptyMap();
Review Comment:
That should work too, but I'd prefer `Collections.emptyMap()` because it is
much simpler implementation and there's actually no state to serialize or copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
