jfz commented on code in PR #5812:
URL: https://github.com/apache/iceberg/pull/5812#discussion_r976961308
##########
aws/src/test/java/org/apache/iceberg/aws/TestAwsProperties.java:
##########
@@ -204,4 +206,21 @@ public void testS3FileIoSessionCredentialsConfiguration() {
"secret",
capturedAwsCredentialsProvider.resolveCredentials().secretAccessKey());
}
+
+ @Test
+ public void testKryoSerialization() throws IOException {
Review Comment:
@rdblue added a test for S3FileIO, also:
- refactored constructor of `AwsProperties` to remove dup code
- applied a similar fix to `PropertyUtil` that is used in `AwsProperties`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
