jackye1995 commented on code in PR #4402:
URL: https://github.com/apache/iceberg/pull/4402#discussion_r980766161
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -394,6 +395,48 @@ public class AwsProperties implements Serializable {
*/
public static final String S3_WRITE_TAGS_PREFIX = "s3.write.tags.";
+ /**
+ * Used by {@link GlueCatalog} to tag objects when writing. To set, we can
pass a catalog
+ * property.
+ *
+ * <p>For more details, see
+ * https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-tagging.html
+ *
+ * <p>Example: s3.write.table-name-tag-enabled=true
+ */
+ public static final String S3_WRITE_TABLE_NAME_TAG_ENABLED =
"s3.write.table-name-tag-enabled";
Review Comment:
I am wondering if we should simplify these config names to
`s3.write.table-tag-enabled`, `s3.write.namespace-tag-enabled`,
`iceberg.table`, `iceberg.namespace`, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
