jackye1995 commented on code in PR #4402:
URL: https://github.com/apache/iceberg/pull/4402#discussion_r981951257
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -394,6 +395,48 @@ public class AwsProperties implements Serializable {
*/
public static final String S3_WRITE_TAGS_PREFIX = "s3.write.tags.";
+ /**
+ * Used by {@link GlueCatalog} to tag objects when writing. To set, we can
pass a catalog
+ * property.
+ *
+ * <p>For more details, see
+ * https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-tagging.html
+ *
+ * <p>Example: s3.write.table-tag-enabled=true
+ */
+ public static final String S3_WRITE_TABLE_TAG_ENABLED =
"s3.write.table-tag-enabled";
+
+ public static final boolean S3_WRITE_TABLE_TAG_ENABLED_DEFAULT = false;
+
+ /**
+ * Used by {@link GlueCatalog} to tag objects when writing. To set, we can
pass a catalog
+ * property.
+ *
+ * <p>For more details, see
+ * https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-tagging.html
+ *
+ * <p>Example: s3.write.namespace-tag-enabled=true
+ */
+ public static final String S3_WRITE_NAMESPACE_TAG_ENABLED =
"s3.write.namespace-tag-enabled";
+
+ public static final boolean S3_WRITE_NAMESPACE_TAG_ENABLED_DEFAULT = false;
+
+ /**
+ * Tag name that will be used by {@link #S3_WRITE_TAGS_PREFIX} when {@link
+ * #S3_WRITE_TABLE_TAG_ENABLED} is enabled
+ *
+ * <p>Example: iceberg.table=tableName
+ */
+ public static final String S3_TAG_TABLE = "iceberg.table";
Review Comment:
what about `S3_TAG_ICEBERG_TABLE`? just to match the value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
