nastra commented on code in PR #5862:
URL: https://github.com/apache/iceberg/pull/5862#discussion_r981241109
##########
core/src/test/java/org/apache/iceberg/TestManifestCaching.java:
##########
@@ -250,6 +236,18 @@ private Table createTable(Map<String, String> properties)
throws Exception {
.create();
}
+ protected HadoopCatalog hadoopCatalog(Map<String, String> catalogProperties)
throws IOException {
Review Comment:
can probably be made private
##########
core/src/test/java/org/apache/iceberg/TestManifestCaching.java:
##########
@@ -178,22 +181,15 @@ public void testWeakFileIOReferenceCleanUp() {
}
}
- System.gc();
+ GcFinalization.awaitFullGc();
Review Comment:
the comment in L188 says `// Insert one more FileIO to trigger cache
eviction.` but aren't we triggering cache eviction already here?
It seems the original version of the test was expecting things to be evicted
only when `IO_MANIFEST_CACHE_MAX_FILEIO_DEFAULT` is reached/exceeded
##########
versions.props:
##########
@@ -10,6 +10,7 @@ org.apache.pig:pig = 0.14.0
com.fasterxml.jackson.*:* = 2.11.4
com.google.errorprone:error_prone_annotations = 2.3.3
com.google.guava:guava = 31.1-jre
+com.google.guava:guava-testlib = 31.1-jre
Review Comment:
nit: you should be able to replace the previous line with
`com.google.guava:* = 31.1-jre`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
