rizaon commented on code in PR #5862:
URL: https://github.com/apache/iceberg/pull/5862#discussion_r981397881
##########
core/src/test/java/org/apache/iceberg/TestManifestCaching.java:
##########
@@ -178,22 +181,15 @@ public void testWeakFileIOReferenceCleanUp() {
}
}
- System.gc();
+ GcFinalization.awaitFullGc();
Review Comment:
I think that comment I made is inherently flawed since I use `System.gc()`.
The main purpose of the test is to verify that cache entry with garbage
collected keys will be removed from the cache, and
`GcFinalization.awaitFullGc()` + `manifestCache.cleanUp()` does evict those
entries. In
[572f0ca](https://github.com/apache/iceberg/pull/5862/commits/572f0ca0322f0974ad0b31ac4c184bce8b91ef84),
I simplified testWeakFileIOReferenceCleanUp by not exceeding
IO_MANIFEST_CACHE_MAX_FILEIO_DEFAULT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
