aokolnychyi commented on code in PR #5740:
URL: https://github.com/apache/iceberg/pull/5740#discussion_r989511316
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -662,15 +709,22 @@ private Pair<Table, Long>
loadFromPathIdentifier(PathIdentifier ident) {
"Cannot specify both snapshot-id and as-of-timestamp: %s",
ident.location());
- Table table =
+ Preconditions.checkArgument(
+ !isChangelog || (snapshotId == null && asOfTimestamp == null),
+ "Cannot specify snapshot-id and as-of-timestamp for changelogs");
+
+ org.apache.iceberg.Table table =
tables.load(parsed.first() + (metadataTableName != null ? "#" +
metadataTableName : ""));
- if (snapshotId != null) {
- return Pair.of(table, snapshotId);
+ if (isChangelog) {
+ return new SparkChangelogTable(table, !cacheEnabled);
+ } else if (snapshotId != null) {
+ return new SparkTable(table, snapshotId, !cacheEnabled);
} else if (asOfTimestamp != null) {
- return Pair.of(table, SnapshotUtil.snapshotIdAsOfTime(table,
asOfTimestamp));
+ return new SparkTable(
+ table, SnapshotUtil.snapshotIdAsOfTime(table, asOfTimestamp),
!cacheEnabled);
} else {
- return Pair.of(table, null);
+ return new SparkTable(table, null, !cacheEnabled);
Review Comment:
I tried but it seemed like an overkill as it is just a single place where it
makes sense. However, I did refactor this part a bit so it should be slightly
better now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
