aokolnychyi commented on code in PR #5740:
URL: https://github.com/apache/iceberg/pull/5740#discussion_r989553492
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -633,13 +672,21 @@ private Pair<String, List<String>>
parseLocationString(String location) {
}
}
- private Pair<Table, Long> loadFromPathIdentifier(PathIdentifier ident) {
+ @SuppressWarnings("CyclomaticComplexity")
+ private Table loadFromPathIdentifier(PathIdentifier ident) {
Pair<String, List<String>> parsed = parseLocationString(ident.location());
String metadataTableName = null;
Long asOfTimestamp = null;
Long snapshotId = null;
+ boolean isChangelog = false;
+
for (String meta : parsed.second()) {
+ if (meta.equalsIgnoreCase(SparkChangelogTable.TABLE_NAME)) {
Review Comment:
I double checked this and I think we should follow the existing logic for
path-based tables where the order of parts in a selector does not matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
